-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585/
-----------------------------------------------------------

(Updated July 18, 2015, 8:38 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-3061
    https://issues.apache.org/jira/browse/MESOS-3061


Repository: mesos


Description (updated)
-------

This would allow Mesos-DNS to lookup container information such as its
IP address.

NOTE: Apparently, the data size is about 15KB per `docker inspect` blob and 
that might addup for large clusters. One suggestion is to expose only the IP 
field(s) from:

    "NetworkSettings": {
        "Bridge": "",
        "EndpointID": 
"c9d8bfb120503eda3dc88ffdcc5778cff4e7f05bb2e53f9b2fba82972ecfe3da",
        "Gateway": "172.17.42.1",
        "GlobalIPv6Address": "",
        "GlobalIPv6PrefixLen": 0,
        "HairpinMode": false,
        "IPAddress": "172.17.0.5",
        "IPPrefixLen": 16,
        "IPv6Gateway": "",
        "LinkLocalIPv6Address": "",
        "LinkLocalIPv6PrefixLen": 0,
        "MacAddress": "02:42:ac:11:00:05",
        "NetworkID": 
"f36472f7725507d90ab10215d35d020bf3eaf5ebdc024cb5b3ffff773967d9fc",
        "PortMapping": null,
        "Ports": {},
        "SandboxKey": "/var/run/docker/netns/3c3d4d0f5e18",
        "SecondaryIPAddresses": null,
        "SecondaryIPv6Addresses": null
    },

An alternate is to use a hook module to decorate TaskStatus with IP information 
extracted from the output of `docker inspect`.


Diffs (updated)
-----

  src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d 
  src/tests/docker_containerizer_tests.cpp 
6c6f4b7f30cec9b5bba77234b714e96289c82b43 

Diff: https://reviews.apache.org/r/36585/diff/


Testing
-------

sudo make check


Thanks,

Kapil Arya

Reply via email to