-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36586/#review92326
-----------------------------------------------------------

Ship it!


Looks good, just a question around whether we want to be testing for 
'FrameworkID' being set correctly, in order to distinguish subscription from 
re-subscription (yet another time that re-subscription seems to be a useful 
concept ;)).


src/tests/rate_limiting_tests.cpp (lines 134 - 136)
<https://reviews.apache.org/r/36586/#comment146421>

    Note that in these tests, we've lost the fact that some of these subscribe 
calls should not have a FrameworkID (i.e. register) and some should have a 
FrameworkID (i.e. re-register). I suppose we were technically not testing this 
before, but at least we had more confidence given the different types of the 
messages.
    
    Should we be adding in some expectations for 'FrameworkID' being set/unset 
appropriately?


- Ben Mahler


On July 17, 2015, 11:08 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36586/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 11:08 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3055
>     https://issues.apache.org/jira/browse/MESOS-3055
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 
>   src/tests/master_tests.cpp 1e934c4b168a0afabd5065e2c8ffa131362ed29b 
>   src/tests/rate_limiting_tests.cpp 6a93df086bc0f256c7750d06f950d61f2dfb7b5c 
>   src/tests/slave_recovery_tests.cpp de2fc280abae98a5fbbeae6e230a1bfdaf0fc86e 
> 
> Diff: https://reviews.apache.org/r/36586/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to