----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92368 -----------------------------------------------------------
Bad patch! Reviews applied: [36513] Failed command: ./support/apply-review.sh -n -r 36513 Error: 2015-07-21 03:37:30 URL:https://reviews.apache.org/r/36513/diff/raw/ [5680/5680] -> "36513.patch" [1] 36513.patch:11: trailing whitespace. # Licensed under the Apache License, Version 2.0 (the "License"); you 36513.patch:12: trailing whitespace. # may not use this file except in compliance with the License. You may 36513.patch:13: trailing whitespace. # obtain a copy of the License at 36513.patch:15: trailing whitespace. # http://www.apache.org/licenses/LICENSE-2.0 36513.patch:17: trailing whitespace. # Unless required by applicable law or agreed to in writing, software warning: squelched 11 whitespace errors warning: 16 lines add whitespace errors. Successfully applied: [MESOS-898] Add CMake-based build system for Mesos project This is the first of two commits that will introduce a CMake-based build system for the Mesos project. These commits are split along the libprocess boundary -- this first commit will provide the CMake build logic for the "core Mesos" project, while the second one will introduce the CMake build logic for the process library. They are committed independently to provide a natural history boundary between the two projects. CMake provides a number of advantages over the Make-based build system currently in place. The most obvious of these is much greater platform independence -- CMake supports a wide variety of platforms and environments (even Visual Studio on Windows), which opens Mesos up for contributions from organizations with drastically different toolchains than the current Mesos default. The second is that this gives us an opportunity to audit the existing build system. The plan moving forward is to develop the CMake build system incrementally and in paralllel to the autoconf build system. Review: https://reviews.apache.org/r/36513 CMakeLists.txt:5: trailing whitespace. +# Licensed under the Apache License, Version 2.0 (the "License"); you CMakeLists.txt:6: trailing whitespace. +# may not use this file except in compliance with the License. You may CMakeLists.txt:7: trailing whitespace. +# obtain a copy of the License at CMakeLists.txt:9: trailing whitespace. +# http://www.apache.org/licenses/LICENSE-2.0 CMakeLists.txt:11: trailing whitespace. +# Unless required by applicable law or agreed to in writing, software CMakeLists.txt:12: trailing whitespace. +# distributed under the License is distributed on an "AS IS" BASIS, CMakeLists.txt:14: trailing whitespace. +# See the License for the specific language governing permissions and CMakeLists.txt:15: trailing whitespace. +# limitations under the License. cmake/MesosConfigure.cmake:5: trailing whitespace. +# Licensed under the Apache License, Version 2.0 (the "License"); you cmake/MesosConfigure.cmake:6: trailing whitespace. +# may not use this file except in compliance with the License. You may cmake/MesosConfigure.cmake:7: trailing whitespace. +# obtain a copy of the License at cmake/MesosConfigure.cmake:9: trailing whitespace. +# http://www.apache.org/licenses/LICENSE-2.0 cmake/MesosConfigure.cmake:11: trailing whitespace. +# Unless required by applicable law or agreed to in writing, software cmake/MesosConfigure.cmake:12: trailing whitespace. +# distributed under the License is distributed on an "AS IS" BASIS, cmake/MesosConfigure.cmake:14: trailing whitespace. +# See the License for the specific language governing permissions and cmake/MesosConfigure.cmake:15: trailing whitespace. +# limitations under the License. Failed to commit patch - Mesos ReviewBot On July 20, 2015, 7:33 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36514/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Timothy > St. Clair. > > > Repository: mesos > > > Description > ------- > > This commit is the second in a series of two commits that will introduce > a CMake-based build system for Mesos. The first introduced the build > system for the "core Mesos" project; this one will introduce a similar > system for the process library. > > For more details see the "core Mesos" commit. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt PRE-CREATION > 3rdparty/libprocess/CMakeLists.txt PRE-CREATION > 3rdparty/libprocess/cmake/ProcessConfigure.cmake PRE-CREATION > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake PRE-CREATION > 3rdparty/libprocess/cmake/macros/External.cmake PRE-CREATION > 3rdparty/libprocess/cmake/macros/PatchCommand.cmake PRE-CREATION > 3rdparty/libprocess/src/CMakeLists.txt PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION > CMakeLists.txt PRE-CREATION > cmake/MesosConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/36514/diff/ > > > Testing > ------- > > Includes tests for the process library that all run and pass. > > > Thanks, > > Alex Clemmer > >
