-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/#review92513
-----------------------------------------------------------



src/hook/manager.cpp (line 212)
<https://reviews.apache.org/r/36580/#comment146723>

    There are a couple of reasons for the pattern (here and in TaskInfo):
    
    1. A decorator hooks can also act as "undecorator" hooks, i.e., it is 
allowed to remove labels from the given TaskStatus/TaskInfo. Thus everytime a 
hook is called, it is called with the current state of TaskInfo/TaskStatus 
Labels.
    2. There can be multiple hooks for label decoration, so we can't simply 
return on `result.isSome()`. We need to accumulate all of those.


- Kapil Arya


On July 21, 2015, 12:46 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36580/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 12:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows Slave modules to expose some information to the
> frameworks as well as Mesos-DNS via state.json.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f 
>   src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab 
>   src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc 
>   src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf 
>   src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 
>   src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db 
> 
> Diff: https://reviews.apache.org/r/36580/diff/
> 
> 
> Testing
> -------
> 
> make check with a new hook test.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to