-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36424/
-----------------------------------------------------------

(Updated July 22, 2015, 6:20 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Cody Maloney, and Paul 
Brett.


Changes
-------

Addressed Alex comments; improved comments.


Bugs: MESOS-3035
    https://issues.apache.org/jira/browse/MESOS-3035


Repository: mesos


Description
-------

Jira: MESOS-2902

While researching how to execute an arbitrary script
to detect the Master IP address, it emerged clearly that
a helper method to execute an arbitrary command/script on
a node and obtain either stdout or stderr would have been
useful and avoided a lot of code repetition.

This could not be ultimately used for the purpose at hand,
but I believe it to be useful enough (particularly, to avoid
people doing "coding by copy&paste" and/or waste time
researching the same functionality).

This would also be beneficial in MESOS-2830 and MESOS-2834
factoring out the remote command execution logic.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/subprocess.hpp 
310cb4f8e4e2faa5545dffd196d7490c868bc5d6 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
f6acb204582a9e696c3b09d4e4c543bb052e97d4 

Diff: https://reviews.apache.org/r/36424/diff/


Testing
-------

make check


Thanks,

Marco Massenzio

Reply via email to