----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92630 -----------------------------------------------------------
Can you write a test for this? include/mesos/mesos.proto (line 374) <https://reviews.apache.org/r/36663/#comment146852> s/ip_address/address/ see below. include/mesos/mesos.proto (line 378) <https://reviews.apache.org/r/36663/#comment146845> s/; can be configured using the --port flag// Mention that this is deprecated in favor of 'address'. include/mesos/mesos.proto (line 389) <https://reviews.apache.org/r/36663/#comment146846> s/eg/e.g./ include/mesos/mesos.proto (line 390) <https://reviews.apache.org/r/36663/#comment146853> Mention that this is deprecated in favor of 'address'. include/mesos/mesos.proto (line 398) <https://reviews.apache.org/r/36663/#comment146847> Lets use the newly created Address protobuf for this. optional Address address; The goal is to use this protobuf for conveying address of a component going forward. We are already using this in Offer. src/common/protobuf_utils.cpp (lines 185 - 191) <https://reviews.apache.org/r/36663/#comment146855> See how we set 'address' protobuf in Master::offer() and do thte same. src/master/master.cpp (lines 326 - 328) <https://reviews.apache.org/r/36663/#comment146856> ditto. - Vinod Kone On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36663/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:50 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2736 > https://issues.apache.org/jira/browse/MESOS-2736 > > > Repository: mesos > > > Description > ------- > > As part of the new HTTP API and the need to > provide a better interface for clients that > do not integrate libmesos, we provide the IP > address of the Leader Master in string format; > this will eventually supersed the int32 existing > `ip`, which also cannot support IPv6 addresses. > > Jira: MESOS-2736 > > > Diffs > ----- > > include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 > src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 > src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 > > Diff: https://reviews.apache.org/r/36663/diff/ > > > Testing > ------- > > make check > (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the > information serialized to ZK is readable and as expected). > > > Thanks, > > Marco Massenzio > >
