> On July 21, 2015, 10:59 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 676 > > <https://reviews.apache.org/r/36656/diff/1/?file=1018171#file1018171line676> > > > > s/protocol/protocols/
Now that we're only referring to SSL-V3, I think it should be: `s/conditionally test these protocol/conditionally test for this protocol/` - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92492 ----------------------------------------------------------- On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36656/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:51 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-3121 > https://issues.apache.org/jira/browse/MESOS-3121 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.hpp > 3f8d351589f8bb26c886da12c53b5e02a242376a > 3rdparty/libprocess/src/openssl.cpp > 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 2fe50601615b0bee57bd3e05dc9c932f93ca7477 > > Diff: https://reviews.apache.org/r/36656/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
