----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92640 -----------------------------------------------------------
Sorry, most of the issues I raised in this review are unrelated to the changes in this patch. docs/mesos-ssl.md (line 5) <https://reviews.apache.org/r/36658/#comment146864> We should have a space after `#` for headings (e.g. `# Configuration`). Here and below. docs/mesos-ssl.md (line 8) <https://reviews.apache.org/r/36658/#comment146865> We don't seem to wrap "Mesos 0.23.0" in backquotes in the rest of our docs. docs/mesos-ssl.md (line 21) <https://reviews.apache.org/r/36658/#comment146867> `s/http/HTTP/` docs/mesos-ssl.md (line 24) <https://reviews.apache.org/r/36658/#comment146868> `s/this binary/Mesos`? `SSL_CERT_FILE` is an environment variable, so it's not necessarily specific to a binary, right? docs/mesos-ssl.md (line 35) <https://reviews.apache.org/r/36658/#comment146866> Should this be something like `SSL_VERIFY_DEPTH=(N)`? `4` isn't the only possible value right? docs/mesos-ssl.md (line 51) <https://reviews.apache.org/r/36658/#comment146862> 1. `s/SSLV2/SSL V2/` since we wrote `TLS V1.2` rather than `TLSV1.2` or something like that? 4. `s/if you understand the risks fully/if you fully understand the risks/` docs/mesos-ssl.md (line 74) <https://reviews.apache.org/r/36658/#comment146869> `s/_Please note:_/__NOTE:__/`? docs/mesos-ssl.md (line 85) <https://reviews.apache.org/r/36658/#comment146870> 1. `s/_Please note:_/__NOTE:__/`? 2. `s/talk/speak/` or whatever term we're using to describe SSL communication. docs/mesos-ssl.md (line 88) <https://reviews.apache.org/r/36658/#comment146871> `s/SSL_SUPPORT_DOWNGRADE/`SSL_SUPPORT_DOWNGRADE`/` - Michael Park On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36658/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:51 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-3121 > https://issues.apache.org/jira/browse/MESOS-3121 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 > docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 > > Diff: https://reviews.apache.org/r/36658/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
