-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36715/#review92809
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/process.cpp (line 647)
<https://reviews.apache.org/r/36715/#comment147055>

    How about we put it in the 'process' namespace. Or even 'process::internal' 
namespace.



3rdparty/libprocess/src/process.cpp (line 825)
<https://reviews.apache.org/r/36715/#comment147056>

    Let's take the address of the function, to denote a function pointer 
(recent bug with this and clang).


- Benjamin Hindman


On July 23, 2015, 7:49 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36715/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
>     https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 45aa2a6019dc08da287b7c8a9d799619deb69747 
>   3rdparty/libprocess/src/libev.cpp 8960c75010e3ceca3486a1fbb0fdeeffd62f4ec8 
>   3rdparty/libprocess/src/libevent.cpp 
> 02f9e61c1357e7b450e53b252b49d1979e782ae8 
>   3rdparty/libprocess/src/process.cpp 
> d6b0d5517964bf7c7276689e801a38b34a3f9db2 
> 
> Diff: https://reviews.apache.org/r/36715/diff/
> 
> 
> Testing
> -------
> 
> make check with libev, libevent
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to