----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92852 -----------------------------------------------------------
LGTM, just some minor comments. 3rdparty/libprocess/src/http.cpp (line 707) <https://reviews.apache.org/r/36757/#comment147101> Explicitly capturing url by reference should be fine here ? If not, just pass in the scheme as argument to reduce overhead of copying the entire URL struct. 3rdparty/libprocess/src/http.cpp (line 708) <https://reviews.apache.org/r/36757/#comment147107> Personally speaking, I don't mind the usage of this lambda here assuming this is the only place where we create sockets. Do we have a separate function for POST too that would also need this logic or it just calls into this function ? 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 974) <https://reviews.apache.org/r/36757/#comment147102> nitpick: s/getUrl/url 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 980) <https://reviews.apache.org/r/36757/#comment147104> Won't just http::get(url); suffice here minus the empty default headers ? 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 985) <https://reviews.apache.org/r/36757/#comment147105> Nitpick : s/string/const string 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 988) <https://reviews.apache.org/r/36757/#comment147100> Can we also check if the response returned is what you had sent/expected i.e. status code is 200 ? - Anand Mazumdar On July 24, 2015, 12:32 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36757/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:32 a.m.) > > > Review request for mesos, Joris Van Remoortere and Timothy Chen. > > > Bugs: MESOS-3093 > https://issues.apache.org/jira/browse/MESOS-3093 > > > Repository: mesos > > > Description > ------- > > Current http implementation lacks a https interface. This change exposes > SSL socket for "https" URL scheme. > > JIRA: MESOS-3093 > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 2fe50601615b0bee57bd3e05dc9c932f93ca7477 > > Diff: https://reviews.apache.org/r/36757/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
