-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92942
-----------------------------------------------------------

Ship it!


Ship It!


src/slave/containerizer/isolator.hpp (line 19)
<https://reviews.apache.org/r/36763/#comment147202>

    Just wondering if we ever decided on a standard on these, seems odd to see 
just ISOLATOR_HPP here and MESOS_SLAVE_ISOLATOR in the include.


- Timothy Chen


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
>     https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to