-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review92954
-----------------------------------------------------------



src/tests/mesos.hpp (lines 1300 - 1303)
<https://reviews.apache.org/r/36761/#comment147213>

    Why stick this in between the two SendStatusUpdate overloads? I would pull 
this below #1313



src/tests/slave_tests.cpp (line 2450)
<https://reviews.apache.org/r/36761/#comment147214>

    s/task/task message/



src/tests/slave_tests.cpp (line 2490)
<https://reviews.apache.org/r/36761/#comment147216>

    new line.



src/tests/slave_tests.cpp (line 2529)
<https://reviews.apache.org/r/36761/#comment147217>

    s/an/a/



src/tests/slave_tests.cpp (line 2537)
<https://reviews.apache.org/r/36761/#comment147218>

    s/,/;/



src/tests/slave_tests.cpp (line 2561)
<https://reviews.apache.org/r/36761/#comment147219>

    s/fail over/restart/ ?



src/tests/slave_tests.cpp (line 2641)
<https://reviews.apache.org/r/36761/#comment147220>

    s/Fail over/Restart/



src/tests/slave_tests.cpp (line 2661)
<https://reviews.apache.org/r/36761/#comment147222>

    s/update/Update/



src/tests/slave_tests.cpp (line 2667)
<https://reviews.apache.org/r/36761/#comment147223>

    s/an/a/



src/tests/slave_tests.cpp (line 2669)
<https://reviews.apache.org/r/36761/#comment147224>

    s/driver/scheduler driver/



src/tests/slave_tests.cpp (line 2699)
<https://reviews.apache.org/r/36761/#comment147225>

    nice tests/


- Vinod Kone


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
>     https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to