> On July 24, 2015, 7:23 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 1025-1029
> > <https://reviews.apache.org/r/36757/diff/4/?file=1021132#file1021132line1025>
> >
> >     Why do you need a std::stringstream for this? We can simplify with just 
> > a string, and also construct it like the protocol exposes:
> >     
> >     string buffer =
> >       "HTTP/1.1 200 OK\r\n" +
> >       "Content-Length : " + stringify(data.length()) + "\r\n" +
> >       "\r\n" +
> >       data;
> >       
> >     Same for test above too.

Only for efficiency reasons. string+ operator will create temp objects.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92966
-----------------------------------------------------------


On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 5:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
>     https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to