> On July 24, 2015, 6:36 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 3199 > > <https://reviews.apache.org/r/36759/diff/1/?file=1020561#file1020561line3199> > > > > i would just put the quote in the next line. > > > > here and everywhere else below.
Really? That looks less readable IMO, easier to make mistakes that way by forgetting the close quote as well, no? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36759/#review92939 ----------------------------------------------------------- On July 24, 2015, 1:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36759/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 1:45 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3132 > https://issues.apache.org/jira/browse/MESOS-3132 > > > Repository: mesos > > > Description > ------- > > This enables the slave to forward messages through the master. > > > Diffs > ----- > > src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec > src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 > src/master/metrics.hpp d37d74a472a3e5605a4689420513f56e713aa8f3 > src/master/metrics.cpp 10e2937c2364b4025ec44ddfe47c3cb958a62773 > src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e > > Diff: https://reviews.apache.org/r/36759/diff/ > > > Testing > ------- > > Added tests in [r/36761](https://reviews.apache.org/r/36761/). > > > Thanks, > > Ben Mahler > >