----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/#review93063 -----------------------------------------------------------
Patch looks great! Reviews applied: [36822, 36823, 36824, 36825, 36826, 36827, 36828, 36829, 36830] All tests passed. - Mesos ReviewBot On July 26, 2015, 9:01 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36830/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 9:01 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-3122 > https://issues.apache.org/jira/browse/MESOS-3122 > > > Repository: mesos > > > Description > ------- > > use --enable-static-unimplemented to get compile time errors as opposed > to runtime errors. > > > Diffs > ----- > > 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb > > Diff: https://reviews.apache.org/r/36830/diff/ > > > Testing > ------- > > created a function with an `UNIMPLEMENTED()` body and verified the runtime > error occured when configured by default, and a compile-time error ocurred > when configured with `--enable-static-unimplemented` > > > Thanks, > > Joris Van Remoortere > >
