> On July 26, 2015, 4:18 p.m., Jojy Varghese wrote:
> > src/master/http.cpp, line 359
> > <https://reviews.apache.org/r/36720/diff/3/?file=1021869#file1021869line359>
> >
> >     Why not static initialization pattern :
> >     OK ok = {
> >            .type = Response::PIPE,
> >            .reader = pipe.reader(),
> >        };
> >        
> >     Maybe its not allowed in  the coding style but I would think it looks 
> > elegant.

Good point. I don't think reading anywhere it not being allowed in the style 
guide. Since OK was a derived struct from Response, I had already added a TODO 
to add a constructor to OK for now to be in sync with the style used in our 
code-base.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review93048
-----------------------------------------------------------


On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36720/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 2:32 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2294
>     https://issues.apache.org/jira/browse/MESOS-2294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Split review out of r36318. This change adds the functionality of making a 
> http call for subscribe and the master responding with a subscribed event on 
> the persistent stream.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 
>   src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca 
>   src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac 
> 
> Diff: https://reviews.apache.org/r/36720/diff/
> 
> 
> Testing
> -------
> 
> make check + test.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to