----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36823/#review93160 -----------------------------------------------------------
src/tests/containerizer/cgroups_tests.cpp (line 817) <https://reviews.apache.org/r/36823/#comment147428> Mind moving this up to the previous line? src/tests/containerizer/cgroups_tests.cpp (lines 820 - 824) <https://reviews.apache.org/r/36823/#comment147429> I'm not convinced that we will _always_ start all threads before doing 'cond.notify_all()' in the main thread, which could mean that when we 'join' we'll wait forever. Technically the test would fail in this circumstance (and I haven't heard about this test being flaky), but at least the test would always clean up in those cases where as now we might block forever. What about just using a 'Latch' here that we open trigger the latch then any stragglers will just fall through? - Benjamin Hindman On July 27, 2015, 6:57 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36823/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 6:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael > Park. > > > Bugs: MESOS-3120 > https://issues.apache.org/jira/browse/MESOS-3120 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/cgroups_tests.cpp > caecd5dfa3fef33dba35cfc1b5934a11e2cc961a > > Diff: https://reviews.apache.org/r/36823/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh > --gtest_filter="CgroupsAnyHierarchyWithFreezerTest.*" > > > Thanks, > > Joris Van Remoortere > >
