-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/#review93167
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 107)
<https://reviews.apache.org/r/36828/#comment147439>

    Not yours but can you bump to previous line please?



3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 125)
<https://reviews.apache.org/r/36828/#comment147438>

    Same comments here as previous reviews: use Latch instead of condition 
variables here.


- Benjamin Hindman


On July 27, 2015, 7:04 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36828/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 7:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3118
>     https://issues.apache.org/jira/browse/MESOS-3118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 
> 5d24f21f63433b8525370736dd630880d324ebeb 
> 
> Diff: https://reviews.apache.org/r/36828/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to