> On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1325-1332 > > <https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325> > > > > Why do we need to recover resources for unreserve?
If reserved resources are offered, we need to recover the reserved resources before we proceed to updating them to be unreserved. > On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 1291 > > <https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1291> > > > > As in https://reviews.apache.org/r/35702/, I suggest we extract > > validation into a separate function. In https://reviews.apache.org/r/35702/, I suggested that we should refactor the validation logic uniformly in all of the endpoints as a separate task. Is that reasonable? - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review91890 ----------------------------------------------------------- On June 28, 2015, 8:37 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35983/ > ----------------------------------------------------------- > > (Updated June 28, 2015, 8:37 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris > Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2600 > https://issues.apache.org/jira/browse/MESOS-2600 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df > > Diff: https://reviews.apache.org/r/35983/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
