> On July 27, 2015, 5:58 p.m., Marco Massenzio wrote: > > src/Makefile.am, lines 933-940 > > <https://reviews.apache.org/r/36819/diff/1/?file=1022016#file1022016line933> > > > > please don't just comment out a bunch of lines of code without > > explaining why you do this - is there a TODO there? why are you commenting > > out, instead of removing them? > > > > Also, isn't this patch about exactly that TODO(benh)? shouldn't you > > remove it? or comment?
Forgot to delete it, let me update. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93141 ----------------------------------------------------------- On July 26, 2015, 5:24 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36819/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 5:24 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3149 > https://issues.apache.org/jira/browse/MESOS-3149 > > > Repository: mesos > > > Description > ------- > > Use setup.py in python cli package. > > > Diffs > ----- > > Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e > bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 > configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 > src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 > src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef > src/cli/python/mesos/cli.py > src/cli/python/mesos/futures.py > src/cli/python/mesos/http.py > src/python/cli/src/mesos/__init__.py PRE-CREATION > > Diff: https://reviews.apache.org/r/36819/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >