-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/#review93252
-----------------------------------------------------------



3rdparty/libprocess/include/process/process.hpp (line 382)
<https://reviews.apache.org/r/36821/#comment147605>

    let's call it `absolutePath`.



3rdparty/libprocess/src/process.cpp (lines 747 - 753)
<https://reviews.apache.org/r/36821/#comment147606>

    Can you move this to a new file `firewall.cpp`



3rdparty/libprocess/src/process.cpp (lines 2242 - 2270)
<https://reviews.apache.org/r/36821/#comment147607>

    This chunk of code will need to be move after `if !(receiver && delegate != 
"")` and before the `if (receiver)`. Not that if you resolve the paths before, 
they still can come without a delegate here.


- Alexander Rojas


On July 28, 2015, 9:30 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36821/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 9:30 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-3143
>     https://issues.apache.org/jira/browse/MESOS-3143
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix disable endpoints rule fails to recognize HTTP path delegates.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/firewall.hpp 
> f92a6c5bbd4af0cab43e487b0c347c30059cf162 
>   3rdparty/libprocess/include/process/process.hpp 
> 8620547148f8a69d5b661eaf08063ca72347b6a4 
>   3rdparty/libprocess/src/process.cpp 
> 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
> 
> Diff: https://reviews.apache.org/r/36821/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to