-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93288
-----------------------------------------------------------



src/tests/fetcher_cache_tests.cpp (line 368)
<https://reviews.apache.org/r/36889/#comment147669>

    s/EXPECT_NE/ASSERT_NE



src/tests/fetcher_cache_tests.cpp (line 568)
<https://reviews.apache.org/r/36889/#comment147661>

    s/EXPECT_SOME/ASSERT_SOME, as Try::isSome() is expected true in the next 
line. There are probably more cases like this.



src/tests/fetcher_cache_tests.cpp (line 606)
<https://reviews.apache.org/r/36889/#comment147662>

    s/EXPECT_SOME/ASSERT_SOME



src/tests/fetcher_cache_tests.cpp (line 656)
<https://reviews.apache.org/r/36889/#comment147664>

    s/EXPECT_SOME/ASSERT_SOME



src/tests/fetcher_cache_tests.cpp (line 693)
<https://reviews.apache.org/r/36889/#comment147665>

    s/EXPECT_SOME/ASSERT_SOME



src/tests/fetcher_cache_tests.cpp (line 729)
<https://reviews.apache.org/r/36889/#comment147666>

    s/EXPECT_SOME/ASSERT_SOME



src/tests/fetcher_cache_tests.cpp (line 867)
<https://reviews.apache.org/r/36889/#comment147667>

    s/EXPECT_SOME/ASSERT_SOME



src/tests/fetcher_cache_tests.cpp (line 930)
<https://reviews.apache.org/r/36889/#comment147668>

    s/EXPECT_SOME/ASSERT_SOME


- Jan Schlicht


On July 28, 2015, 2:52 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
> 
> 
> Bugs: MESOS-3112
>     https://issues.apache.org/jira/browse/MESOS-3112
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on 
> the outcome.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 
> 
> Diff: https://reviews.apache.org/r/36889/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to