----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/#review93316 -----------------------------------------------------------
Ship it! Please do a rebase. The patch does not apply. src/tests/containerizer/port_mapping_tests.cpp (lines 320 - 322) <https://reviews.apache.org/r/36831/#comment147700> Could you reverse this: ``` if (preparation.get().commands().size() != 1) { ... } ``` - Jie Yu On July 28, 2015, 3:45 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36831/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 3:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Previously, the Isolators had to join all the preparation commands into > a single command using `&&`. Now they can pass each command separately. > > > Diffs > ----- > > include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 > src/slave/containerizer/isolators/filesystem/shared.cpp > 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc > src/slave/containerizer/isolators/namespaces/pid.cpp > 29be94b96ed9a3db90c88a4b60517d78e95b7144 > src/slave/containerizer/isolators/network/port_mapping.cpp > 3f35782c9e0e458169777bab778178c524a58b2b > src/slave/containerizer/mesos/containerizer.cpp > 11eedf30674b326ea3e1f6f71d27f9eb54126368 > src/tests/containerizer/containerizer_tests.cpp > a44b6e887c37e55213db068a95ab3e73a033e1ea > src/tests/containerizer/isolator_tests.cpp > 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 > src/tests/containerizer/port_mapping_tests.cpp > 45ef97a4822edacd2c2964e63ec624fe4190b3b9 > > Diff: https://reviews.apache.org/r/36831/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
