-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93432
-----------------------------------------------------------


Please make sure you use hard tabs within our build environment (.am, .ac).


src/Makefile.am (line 261)
<https://reviews.apache.org/r/36908/#comment147799>

    This line looks too long.



src/Makefile.am (lines 478 - 479)
<https://reviews.apache.org/r/36908/#comment147798>

    Are you using hard tabs (8 chars) here?



src/Makefile.am (line 801)
<https://reviews.apache.org/r/36908/#comment147795>

    Not yours, but the ordering here looks weird to me. What do you think, 
should we alphabetize this entire block?
    
    This also looks weird here on RB in terms of spacing of the backslash - 
need to check locally I guess.


- Till Toenshoff


On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to