> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > <https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474> > > > > const Path& > > Jan Schlicht wrote: > Path::basename() is not marked const (which it probably should), hence we > have to iterate over Path by value.
Created a ticket for that: https://issues.apache.org/jira/browse/MESOS-3173 - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93443 ----------------------------------------------------------- On July 29, 2015, 3:59 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36773/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 3:59 p.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Bugs: MESOS-3112 > https://issues.apache.org/jira/browse/MESOS-3112 > > > Repository: mesos > > > Description > ------- > > A linked list is used to keep cache entries in LRU-to-MRU order. Each time an > existing cache entry is requested, it is moved to the back of the list. > During cache eviction entries are removed from the front of the list until > enough cache space can be freed. > > > Diffs > ----- > > docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b > src/slave/containerizer/fetcher.hpp > 17225072ba5c1c9a7209f2923bcf562fcb76201f > src/slave/containerizer/fetcher.cpp > e030deabd5e749100cbccabb256dbd4af8b2fe58 > src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 > > Diff: https://reviews.apache.org/r/36773/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
