----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36919/#review93504 -----------------------------------------------------------
Ship it! nice cleanup! src/master/master.cpp (lines 1697 - 1698) <https://reviews.apache.org/r/36919/#comment147898> Make this LOG(FATAL) then because it's not possible? src/master/validation.cpp (line 55) <https://reviews.apache.org/r/36919/#comment147897> can you put it inside scheduler::call namespace? src/scheduler/scheduler.cpp <https://reviews.apache.org/r/36919/#comment147900> Can you keep this TODO? - Vinod Kone On July 29, 2015, 7:43 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36919/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 7:43 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2497 > https://issues.apache.org/jira/browse/MESOS-2497 > > > Repository: mesos > > > Description > ------- > > Call validation was duplicated across scheduler.cpp and the master. > > With the http api, we will also want an easy way to validate and drop calls > that are coming in to the master. > > > Diffs > ----- > > src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b > src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a > src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 > src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 > src/scheduler/scheduler.cpp 6887ed109a4b7342a460fff2ebbe1d98ff3e9092 > > Diff: https://reviews.apache.org/r/36919/diff/ > > > Testing > ------- > > make check > > This also makes it easier to unit test this validation going forward. > > > Thanks, > > Ben Mahler > >
