-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36625/
-----------------------------------------------------------

(Updated July 29, 2015, 4:18 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Alex Clemmer, 
and Joris Van Remoortere.


Changes
-------

Fix some build issues on Windows:

* inline'd the function in windows/format.hpp.
* Added MAXHOSTNAMELEN definition.


Bugs: MESOS-3101
    https://issues.apache.org/jira/browse/MESOS-3101


Repository: mesos


Description
-------

To support the upcoming Windows Containerizer (MESOS-3094), we're splitting up 
(refactoring) platform specific functions into separate files.

We will avoid having `#ifdef __WINDOWS__` all over the stout/libprcess code by 
separating Posix/Windows versions.
This first patch is to establish a pattern in splitting up the headers.

Patterns:

* gzip.hpp, thread.hpp - Functions are moved to a Posix folder; copied to a 
Windows folder and gutted for later implementation.
* abort.hpp, exit.hpp, unreachable.hpp - Added macro for 
`__attribute__((noreturn))`.
* duration.hpp - An #ifdef for one of the headers (time.h vs Winsock2.h). No 
need to split the header.
* format.hpp - Missing Windows function (vasprintf) implementation added.
* ip.hpp - Added aliases for Windows functions.
* net.hpp - Curl functions were moved to Posix/Windows folders.


Other:

* Instances of #include "local file.hpp" were changed to #include <stout/local 
file.hpp>" to match os.hpp.
* Some missing #endif comments (i.e. `// __APPLE__`) were added.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
3aa9487bed2df038ca27a8bb94c24608ca7910a4 
  3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
bba8303347aac3f70566a9e69625a928cfb1bd24 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
8c16a224433d7a43bf6bf17e1129e6eb9bbbd573 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
0b95819205af6caae05c01cb4d0b25620abe791c 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
a0ea23797376288e8dc96886fd3c0702e5edf846 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
a538fb1a343aab039aecabe508b7747e683fd46e 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/thread.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
552d6e97c882a36d6a889af205c422e51f544b34 
  3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 
fed0a7ba81c98be83a0d66c2317e768877f8e40d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/preprocessor.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/thread.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/36625/diff/


Testing (updated)
-------

`make` and `make check` (Mac OSX).

Build with MSVC Enterprise 2015 [thanks to Alex (hausdorff)].


Thanks,

Joseph Wu

Reply via email to