----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32587/#review93591 -----------------------------------------------------------
src/slave/slave.cpp (line 1242) <https://reviews.apache.org/r/32587/#comment147973> Trailing ' ' in log message. src/slave/slave.cpp (lines 1241 - 1243) <https://reviews.apache.org/r/32587/#comment147974> Maybe just warn and leave the CopyFrom there? Next release, we'll remove the field entirely, and consequently this check too. - Adam B On July 30, 2015, 9:18 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32587/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 9:18 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2559 > https://issues.apache.org/jira/browse/MESOS-2559 > > > Repository: mesos > > > Description > ------- > > FrameworkID can be retrieved from RunTaskMessage.framework. > > NOTE: This patch is only to be merged _ONLY_ after all the dependent patches > have shipped, i.e. after 0.23.0 (tracked here: > https://issues.apache.org/jira/browse/MESOS-2561) has released. > > > Diffs > ----- > > src/master/master.cpp a8a195df07b5a97fdba7dfc5f312bbfa85a0d510 > src/slave/slave.cpp f91fa9204cd89596a3690c55c22e93429392cbfd > src/tests/mesos.cpp f3b731542f9db4f966970ecb2bb96eb828350dea > > Diff: https://reviews.apache.org/r/32587/diff/ > > > Testing > ------- > > make check > > Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) > with 0.23.0 and the current master to verify compatibility checks. > > > Thanks, > > Kapil Arya > >
