> On July 30, 2015, 4:45 p.m., Vinod Kone wrote: > > src/tests/containerizer/launcher.hpp, lines 19-37 > > <https://reviews.apache.org/r/36929/diff/1/?file=1024924#file1024924line19> > > > > why did you remove these headers? > > > > i think we decided to explicitly include all the headers that are used > > in a file instead of depending on transitive includes.
Is there a discussion somewhere? I think explicitly including all headers make it hard to maintain (you'll need to adjust the header when the dependent header changes). Also, it slows down the compilation. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36929/#review93599 ----------------------------------------------------------- On July 30, 2015, 12:14 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36929/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 12:14 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Fixed a few issues in test launcher header. > > > Diffs > ----- > > src/tests/containerizer/launcher.hpp > b80e84196f8b494e6e5a3c96c86f63fe432a7bb0 > > Diff: https://reviews.apache.org/r/36929/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
