-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36783/#review93672
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 29, 2015, 11:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36783/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3102
>     https://issues.apache.org/jira/browse/MESOS-3102
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3102: Stout library header splitting, to support the Windows 
> Containerizer.
> Splits apart os.hpp only.
> 
> See the prior review in the chain for the pattern.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 818560f8ce20126e0aa4af6ce368c973c9616c74 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/preprocessor.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36783/diff/
> 
> 
> Testing
> -------
> 
> `make` and `make check` (Mac OSX).
> 
> Build with MSVC Enterprise 2015 [thanks to Alex (hausdorff)].
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to