----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36954/#review93702 -----------------------------------------------------------
Ship it! src/linux/fs.cpp (lines 515 - 516) <https://reviews.apache.org/r/36954/#comment148114> The exact words on the [man page](http://linux.die.net/man/2/pivot_root): > new_root and put_old must not be on the same file system as the current root So here the comment should be `... requires 'root' to be not on the same filesystem as the process' current root`. - Jiang Yan Xu On July 30, 2015, 3:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36954/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 3:09 p.m.) > > > Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan > Xu. > > > Bugs: MESOS-3178 > https://issues.apache.org/jira/browse/MESOS-3178 > > > Repository: mesos > > > Description > ------- > > Performed a self bind mount of rootfs itself in fs::chroot::enter(). > > See the attached ticket for the motivation. > > > Diffs > ----- > > src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd > > Diff: https://reviews.apache.org/r/36954/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
