> On July 31, 2015, 7:39 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 343
> > <https://reviews.apache.org/r/36946/diff/1/?file=1025117#file1025117line343>
> >
> >     This change seems to eliminate the essence of the test, namely the 
> > leading white space.

There are two UT cases here:

- FetcherTest-OSNetUriTest
- FetcherTest-OSNetUriSpaceTest

This fix only handle #1, which did not handle leading white space :)


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
-----------------------------------------------------------


On July 30, 2015, 4:37 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
>     https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to