-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93860
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37023]

All tests passed.

- Mesos ReviewBot


On Aug. 2, 2015, 9:28 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2015, 9:28 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
>     https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
>   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
>   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
>   src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d 
>   src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
>   src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> -------
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
>   "flags": {
>     "allocation_interval": "1secs",
>     "allocator": "HierarchicalDRF",
>     "authenticate": "false",
>     "authenticate_slaves": "false",
>     "authenticators": "crammd5",
>     "framework_sorter": "drf",
>     "help": "true",
>     "initialize_driver_logging": "true",
>     "log_auto_initialize": "true",
>     "logbufsecs": "0",
>     "logging_level": "INFO",
>     "max_slave_ping_timeouts": "5",
>     "quiet": "false",
>     "recovery_slave_removal_limit": "100%",
>     "registry": "replicated_log",
>     "registry_fetch_timeout": "1mins",
>     "registry_store_timeout": "5secs",
>     "registry_strict": "false",
>     "root_submissions": "true",
>     "slave_ping_timeout": "15secs",
>     "slave_reregister_timeout": "10mins",
>     "user_sorter": "drf",
>     "version": "false",
>     "webui_dir": "/home/haosdent/mesos/build/../src/webui",
>     "work_dir": "/tmp/mesos",
>     "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
>   "flags": {
>     "authenticatee": "crammd5",
>     "cgroups_cpu_enable_pids_and_tids_count": "false",
>     "cgroups_enable_cfs": "false",
>     "cgroups_hierarchy": "/sys/fs/cgroup",
>     "cgroups_limit_swap": "false",
>     "cgroups_root": "mesos",
>     "container_disk_watch_interval": "15secs",
>     "containerizers": "mesos",
>     "default_role": "*",
>     "disk_watch_interval": "1mins",
>     "docker": "docker",
>     "docker_kill_orphans": "true",
>     "docker_remove_delay": "6hrs",
>     "docker_socket": "/var/run/docker.sock",
>     "docker_stop_timeout": "0ns",
>     "enforce_container_disk_quota": "false",
>     "executor_registration_timeout": "1mins",
>     "executor_shutdown_grace_period": "5secs",
>     "fetcher_cache_dir": "/tmp/mesos/fetch",
>     "fetcher_cache_size": "2GB",
>     "frameworks_home": "",
>     "gc_delay": "1weeks",
>     "gc_disk_headroom": "0.1",
>     "hadoop_home": "",
>     "help": "false",
>     "initialize_driver_logging": "true",
>     "isolation": "posix/cpu,posix/mem",
>     "launcher_dir": "/home/haosdent/mesos/build/src",
>     "logbufsecs": "0",
>     "logging_level": "INFO",
>     "oversubscribed_resources_interval": "15secs",
>     "perf_duration": "10secs",
>     "perf_interval": "1mins",
>     "qos_correction_interval_min": "0ns",
>     "quiet": "false",
>     "recover": "reconnect",
>     "recovery_timeout": "15mins",
>     "registration_backoff_factor": "1secs",
>     "resource_monitoring_interval": "1secs",
>     "revocable_cpu_low_priority": "true",
>     "sandbox_directory": "/mnt/mesos/sandbox",
>     "strict": "true",
>     "switch_user": "true",
>     "version": "false",
>     "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to