> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 219 > > <https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219> > > > > This will crash the program if tokens is empty! > > Isabel Jimenez wrote: > This will not crash, tokenize will always return a vector of at least one > if one of the parameter strings is not empty and in this case the second one > is always ";". > > (https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp#L208) > > Ben Mahler wrote: > That is a test of strings::split, here is a tokenize test which returns > an empty vector: > > > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp#L163
Right, my bad, I'll check that accept.get() does not return an empty string then. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94105 ----------------------------------------------------------- On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36402/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 5:42 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and > Vinod Kone. > > > Repository: mesos-incubating > > > Description > ------- > > Adding a method for Accept header in request + refactor of Accept-Encoding > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp b8d9300 > 3rdparty/libprocess/src/http.cpp 4dcbd74 > 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 > > Diff: https://reviews.apache.org/r/36402/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
