> On Aug. 4, 2015, 11:45 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 314-316 > > <https://reviews.apache.org/r/37045/diff/2/?file=1028754#file1028754line314> > > > > Any reason you're changing the style of the failure messages? Let's > > leave them untouched in this patch, since they look goot to me.
I updated the error message because I realized that perf executed but returned an error status, which is of course different from failing to execute perf at all (caught be the test on line 301). - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94148 ----------------------------------------------------------- On Aug. 4, 2015, 4:57 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37045/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 4:57 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > Convert Linux perf sampler to use process:await(). > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/37045/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
