-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review94176
-----------------------------------------------------------



configure.ac (line 544)
<https://reviews.apache.org/r/36811/#comment148717>

    The check should come before we do the AC_SUBST. I don't want to just move 
the AC_SUBST way away from the rest of the protobuf checking code though.
    
    I think it would be better moving the whole protobuf / protobuf.jar check 
section to after the java check, then just update the "if java" check around 
the AC_CHECK_FILE where it was previously.


- Cody Maloney


On Aug. 4, 2015, 9:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36811/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 9:27 a.m.)
> 
> 
> Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2480
>     https://issues.apache.org/jira/browse/MESOS-2480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Don't check protobuf jar when --disable-java flag.
> 
> 
> Diffs
> -----
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36811/diff/
> 
> 
> Testing
> -------
> 
> ../configure --with-protobuf=/usr/local --disable-java
> make -j4
> make check
> ```
> [----------] Global test environment tear-down
> [==========] 644 tests from 91 test cases ran. (431596 ms total)
> [  PASSED  ] 644 tests.
> ```
> 
> ../configure
> make -j4
> make check
> ```
> [----------] Global test environment tear-down
> [==========] 685 tests from 98 test cases ran. (554759 ms total)
> [  PASSED  ] 685 tests.
> ```
> 
> ../configure --disable-java
> make -j4
> make check
> ```
> [----------] Global test environment tear-down
> [==========] 644 tests from 91 test cases ran. (427688 ms total)
> [  PASSED  ] 644 tests.
> ```
> 
> ../configure --with-protobuf=/usr/local
> make -j4
> make check
> ```
> [----------] Global test environment tear-down
> [==========] 685 tests from 98 test cases ran. (551493 ms total)
> [  PASSED  ] 685 tests.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to