> On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote: > > I would say ship it if everyone agrees that this now depends on this python > > package just as a hack to add an empty __init__.py to the google submodule > > for protobuf. > > > > A better solution could be found later of course. > > Sebastien Pahl wrote: > https://pypi.python.org/pypi/google-common
Yes, I think we need add a way to install dependency before build. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94243 ----------------------------------------------------------- On Aug. 5, 2015, 10:29 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37081/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 10:29 a.m.) > > > Review request for mesos, Bernd Mathiske, Kapil Arya, Marco Massenzio, and > Sebastien Pahl. > > > Bugs: MESOS-2337 > https://issues.apache.org/jira/browse/MESOS-2337 > > > Repository: mesos > > > Description > ------- > > Let __init__.py getting installed to > $PREFIX/lib/pythonX.Y/site-packages/mesos. > > > Diffs > ----- > > src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec > src/python/interface/setup.py.in afcaf7ad6851eb36304a3be92c062cb6b21dbb03 > src/python/setup.py.in 304c4bf87870fbaff2de0615cfd2263bb8a7ad3a > > Diff: https://reviews.apache.org/r/37081/diff/ > > > Testing > ------- > > ## Test steps > ### In CentOS 6.6 > ``` > ./bootstrap > mkdir build > cd build > make -j4 > sudo make install > ``` > > And then execute > > ``` > export PYTHONPATH=/usr/local/lib/python2.6/site-packages > python -c "import mesos; from mesos import native; from mesos import > interface" > ``` > > Check it could success or not. > > Also check the `__init__.py` file > ``` > cat /usr/local/lib/python2.6/site-packages/mesos/__init__.py > ``` > > > Thanks, > > haosdent huang > >
