> On Aug. 6, 2015, 5:38 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 661
> > <https://reviews.apache.org/r/37159/diff/1/?file=1033221#file1033221line661>
> >
> >     Where does the provisioner go?
> >     I see it's removed here but I don't see where else we're calling 
> > provisioner to populate the rootfs?

Yes. It'll be moved the the linux filesystem isolator. I am working on that 
right now and will submit that shortly.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37159/#review94357
-----------------------------------------------------------


On Aug. 6, 2015, 4:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37159/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 4:20 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan 
> Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Delegated the container root filesystem provisioning to the filesystem 
> isolator.
> 
> The motivation is that: currently, container rootfs provisioning is done by 
> the containerizer while preparing the rest of the filesystem (i.e., bind 
> mount volumes) is done by the filesystem isolator. It'll be more natural if 
> all filesystem related preparation is done by one component.
> 
> Another reason is that we are going to provision images specified in the 
> volumes as well. So provisining rootfs in filesystem isolator makes it more 
> easy to implement.
> 
> Turns out that this change simplify the containerizer quite a bit.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 22f1e3686f50c3b9290561aa7e5073e24a702824 
>   include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd 
>   src/slave/containerizer/isolator.hpp 
> 710c584f95d60c1931b40ca041409aa819a06cba 
>   src/slave/containerizer/isolator.cpp 
> ed610f9f8fe328fb3b73f620858dc632725e51f8 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 6b980f26fe8bb51dd989a0578337bc13dbd087ad 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> 907d7e78bfb591197e150ac053bb857d15a1e6dc 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> e831878ab47b8455a4831ebe305373130b194a40 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> e343d0b9751b46bc5a4a8ccd32c0b2745e110e6b 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 73f245bc9166e1f7550466ddd97113c63ce44e73 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 0e421cb6ad3e04b71746033ab15d0f1695fcd5e7 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> 4c7a6f2b7530c88c34d533dba9593006ad5284b2 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 4861ee13fc34eef03d28f26d57a7d11aebed81a6 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 45e4ba09993e7b77f2df45a5c86bc00fa2d83977 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> b30ab3fd0013045a2843fe1e8843cc120ce180c6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 858e43683c88ac62abfc74ff28e8073895cf6f64 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 8e643f4afae8c24cd4d68aa349148b6f402b286b 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 2599c9800e3edf12ec883b31c280324b24b195c5 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 8244c345b84108af7fa18d20e71401d6e1a0aeb0 
>   src/slave/containerizer/isolators/posix.hpp 
> ef19749c0d5b795fee54d67cfc0d983b0f7084ec 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> 9fa584ff4a2f3c90c4d81aecefbcba57fa2294ad 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 6dda77bad7ab135b6d339a80b98a291ea7120e95 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 8851d30af56b4f9fb95450ac1f42ab550e3df9ff 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 
>   src/tests/containerizer/isolator.hpp 
> fa2fc9bd6a59de130870f1ab199e05e85579d8dd 
>   src/tests/containerizer/isolator_tests.cpp 
> ff6e2b7e190a58a4809d6e71addb15dabe418e17 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 213fa4b0b9c50eba941ef11116b52497eb32d539 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 4bee74acba2b1472c80cabbc9d0384bd04c543aa 
> 
> Diff: https://reviews.apache.org/r/37159/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to