> On Aug. 6, 2015, 1:21 a.m., Michael Park wrote:
> > src/tests/containerizer/memory_test_helper.cpp, lines 81-83
> > <https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line81>
> >
> >     `mlockall` is not what we want ideally right?
> >     
> >     Can we mention that it's not ideal but that it exists temporarily to 
> > address `MESOS-3197`?

I am not sure. For the purpose of this test (which is to artifficiialy drive 
memory utilization) mlockall() seems to be a safer choice.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94376
-----------------------------------------------------------


On Aug. 6, 2015, 10:34 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 10:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
>     https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to