This is an automatically generated e-mail. To reply, visit:

Review request for mesos.

Bugs: MESOS-3187

Repository: mesos


MESOS-3187, support docker host command line option.

Docker daemon supports starting on a non-default port. Such scenarios would 
needed when starting Docker daemon on TCP or non-default unix port. Mesos slave 
does not work if Docker daemon is started on any of such non-default port. The 
code change is needed in Mesos slave to accept this parameter so as connect for 
its operations to the right Docker daemon. The change is made in Mesos slave, 
so as it is available to any framework making using Docker executor. 

The code is added to start slave binary with --docker_host, instructing it to 
connect on port as specified in the parameter. The default value of 
--default_host is "unix:///var/run/docker.sock, which is default port for 
Docker daemon.

The main class src/docker.cpp/.hpp is kept backward compartible to make Docker 
cli execute on default Docker port.


  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
  src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 
  src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e 
  src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 

Diff: https://reviews.apache.org/r/37114/diff/


Following scenarios were executed to test the code changes. Kindly suggest if 
more test-cases are required:

a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
   i) Start slave with --docker_host parameter 
   ii) Using a framework, in my case Marathon, post a Docker job
   iii) The docker job does get started on the slave, confirmed with docker ps 
command output 
docker -H unix:///var/run/docker_myport.sock ps

CONTAINER ID        IMAGE               COMMAND                CREATED          
   STATUS              PORTS               NAMES
07fc4ec86bac        mygoserver          "/bin/sh -c /mygoser   19 minutes ago   
   Up 19 minutes       */tcp, */udp        

    iv) Stop or destroy the job from Marathon GUI
b) Two mesos slave with non-default docker port
    i) On two different hosts, start slave, with one running on default port 
and other non-default. The start slaves with attributes - default and or 
    ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
slave - non-default & default
    iii) Stop/destroy the jobs
d) Modified unit test-case taking docker port value


Vaibhav Khanduja

Reply via email to