-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94432
-----------------------------------------------------------

Ship it!



src/tests/http_api_tests.cpp (line 137)
<https://reviews.apache.org/r/37192/#comment149033>

    s/though//
    
    s/server/master/



src/tests/http_api_tests.cpp (line 145)
<https://reviews.apache.org/r/37192/#comment149085>

    s/strings/string/ ?



src/tests/http_api_tests.cpp (line 161)
<https://reviews.apache.org/r/37192/#comment149087>

    s/server/master/



src/tests/http_api_tests.cpp (line 199)
<https://reviews.apache.org/r/37192/#comment149088>

    did you need to pull this into a temp variable? why not just use it 
directly in #202?


- Vinod Kone


On Aug. 6, 2015, 5:06 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -----
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to