-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review94468
-----------------------------------------------------------



src/tests/http_api_tests.cpp (line 182)
<https://reviews.apache.org/r/37082/#comment149089>

    AWAIT_READY guarantees that event.isReady(). no need for this check?
    
    here and everywhere.



src/tests/http_api_tests.cpp (line 183)
<https://reviews.apache.org/r/37082/#comment149091>

    No CHECK's in test code please. It will crash the program.
    
    Use ASSERT_SOME() instead.
    
    here and everywhere else.


- Vinod Kone


On Aug. 6, 2015, 4:26 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37082/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 4:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This implements the tests for http framework subscribe/failover/upgrade from 
> a pid based framework. The test are parameterized on content type and hence 
> test both json/protobuf responses.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37082/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to