-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/#review94475
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker.hpp (line 81)
<https://reviews.apache.org/r/37198/#comment149102>

    Let's use a struct instead of a pair here.



src/slave/containerizer/provisioners/docker.cpp (line 163)
<https://reviews.apache.org/r/37198/#comment149103>

    Doesn't seem like this TODO comment means much :) Remove it.



src/slave/containerizer/provisioners/docker.cpp (line 202)
<https://reviews.apache.org/r/37198/#comment149104>

    Remove extra space between [] and (
    
    And also seems like we're doing duplicate functionality here with appc? 
Should be consolidate?



src/slave/flags.cpp (line 81)
<https://reviews.apache.org/r/37198/#comment149101>

    Is this going to be the same with appc? Should we just have one config?


- Timothy Chen


On Aug. 6, 2015, 8:37 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37198/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 8:37 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2850
>     https://issues.apache.org/jira/browse/MESOS-2850
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Docker image provisioner and copy backend.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 
>   src/slave/containerizer/provisioner.hpp 
> cb4d511e8189b65df9b9803f23812dd98edc44ac 
>   src/slave/containerizer/provisioner.cpp 
> df52e36b23ad3cd28f50e96865d0b163cc245cb2 
>   src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
>   src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 
>   src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e 
> 
> Diff: https://reviews.apache.org/r/37198/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to