----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/#review94656 -----------------------------------------------------------
Ship it! Ship It! - Isabel Jimenez On Aug. 8, 2015, 3:32 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37244/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 3:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Bugs: MESOS-3195 > https://issues.apache.org/jira/browse/MESOS-3195 > > > Repository: mesos > > > Description > ------- > > The one difference between the old code and this code is that metrics are not > updated if we drop the call (e.g., framework is unknown or wrong framework). > But I think that's reasonable. > > > Diffs > ----- > > src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 > src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea > src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 > > Diff: https://reviews.apache.org/r/37244/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >