-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/#review94681
-----------------------------------------------------------

Ship it!


I'll get this committed for you since it's been agreed upon that we're going to 
make this style change. I've found following minor fixes, but I'll fix them 
before committing (since the longer we wait, the more we'll have to rebase).


3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp (line 96)
<https://reviews.apache.org/r/37018/#comment149286>

    Removed unnecessary specialization: `<>`.



3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp (line 102)
<https://reviews.apache.org/r/37018/#comment149287>

    `s/!operator == (that);/!(*this == that);` here and below.



3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp (line 87)
<https://reviews.apache.org/r/37018/#comment149288>

    `s/operator []/operator[]/`



3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp (line 115)
<https://reviews.apache.org/r/37018/#comment149289>

    `s/> >/>>/`


Also updated `3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp` which 
was committed after this patch, and has a couple of instances of `operator () 
(...)`.

- Michael Park


On Aug. 9, 2015, 10:16 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37018/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> 39a6a3f26f59915f7a338796558eb19c93788ced 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 451a53d152011db0ca89a8b2e9bf47ba277cf132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 967201888114e01f1a2d3c9cfaae847f1ce42d13 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> 35fb034f303ffda8e786a8cb564b92d02cddbfe9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ae54566b9d0160def6146aa0ce634bdbf0967142 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> 89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 24c26e90d2386bf5319f07c69c20efacb95f12eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 5d7404bed73774644451f74a15c63da32441f529 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> 420d5bbb4c275eed3e663d40501b127d8fc7749f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 0e94e22817e21fc7944a995092e54bf302ab0e2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> bbb796d647e9dd591802722f498cdc2fd39bca3e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
> 70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 5af9be8fe419fe7f798a31dfa399516cd3514f67 
>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
> 0004fa5cd249269504155e51e52cd802c0916851 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> a7de91f73b08494157873dd8a0df8538c22d2e24 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> f0b0a488059e6cbc041697280356d45f3ff95f17 
>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
> ea8a13f25d72bb645842d32a91b168b67d33c3eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 450b3a7e67cf5f49888691d03997b8409004519e 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 984c02c982dc4dd8eb528d79e715847ef7a693b8 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
> d03678552ae222cb8748ac7e57c600f8688761c4 
> 
> Diff: https://reviews.apache.org/r/37018/diff/
> 
> 
> Testing
> -------
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to