> On Aug. 8, 2015, 8:14 p.m., Michael Park wrote:
> > docs/mesos-c++-style-guide.md, line 40
> > <https://reviews.apache.org/r/37013/diff/2/?file=1033909#file1033909line40>
> >
> >     I think we can simply delete this, rather than saying "don't do". What 
> > do you think?
> 
> Artem Harutyunyan wrote:
>     I'm not sure whether or not (new) developers will naturally skip the 
> whitespace around the operators :). But if you think that they will, then 
> sure, we can just remove the line.
> 
> Michael Park wrote:
>     Yeah, it's the norm in the C++ community (C++ Standard, `cppreference`, 
> Scott Meyers' Effective C++ series, ClangFormat, etc).

Removed and committed.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37013/#review94645
-----------------------------------------------------------


On Aug. 8, 2015, 9:57 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37013/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md 3824ec0b11cc2d3e4a2a8409171107839d706a28 
>   docs/mesos-c++-style-guide.md d8ad0acbb5f1484699f06e6748328a1ec0e7957f 
>   include/mesos/resources.hpp d4d5cafd937cccf6c4eff905e3024d53b4594bf7 
>   include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 
>   include/mesos/values.hpp c61f9e87f1e240c71571793d24751fbe53ed45d2 
>   src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
>   src/common/attributes.cpp a8a621e52f0399dbd480437279bdbadf0916f745 
>   src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 
>   src/common/type_utils.cpp 36a2469274abb356376279cf7c2f88cf29c2796e 
>   src/common/values.cpp 2431d9e276072c40061f8626d56a0727b16a088f 
>   src/jvm/jvm.hpp 90febda728e7068f7ace678c55a7061741c748bb 
>   src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
>   src/linux/routing/filter/basic.hpp fea8976b8d4e53be23b2ba838a2091b7187b8e55 
>   src/linux/routing/filter/icmp.hpp b732193aafcbb72a79036cd69418dbfb21428fff 
>   src/linux/routing/filter/ip.hpp ec6f643639879639d56b81e97b4ea7b4b487e1e5 
>   src/linux/routing/handle.hpp 052c7cc1a967797d245a275d08cc774f627398a5 
>   src/log/log.hpp 7c905c7e431b6663af8cdbce94d98c905da878ae 
>   src/log/network.hpp ff3496b2f648944087eaed8b314d64f3671c3f50 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 6aec14f2dbe4476f9c2a857f2d54f30c12c3133d 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 85eef6bbb4c8b3436f0cd345cd9f1c4e8289e110 
>   src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
>   src/master/registrar.hpp c1463c52b835e3dd653e64dcceacdb31b00fca54 
>   src/messages/flags.hpp 17f8bf3aaa2f10d20abac14c4ace845cde251760 
>   src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d 
>   src/messages/messages.hpp f7afcf757696cd210b26ce8dd3a173f036c23da1 
>   src/slave/gc.hpp 780f9c988b72ad3b22db191a62bff62621b15733 
>   src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
>   src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 
>   src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
>   src/zookeeper/authentication.hpp 1c503077cd577cd0440e62d7b9c7ddf128bbceab 
>   src/zookeeper/group.hpp 9e0ed327aec6f26982984d8fd379dbd6140589b3 
>   src/zookeeper/url.hpp b4253e86c0e597a737e83a9660d29ea9748bf285 
>   src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 
> 
> Diff: https://reviews.apache.org/r/37013/diff/
> 
> 
> Testing
> -------
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to