----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94959 -----------------------------------------------------------
src/scheduler/scheduler.cpp (lines 328 - 332) <https://reviews.apache.org/r/37303/#comment149702> can you use the response decoder here? src/scheduler/scheduler.cpp (line 329) <https://reviews.apache.org/r/37303/#comment149689> indent by 4 spaces. src/scheduler/scheduler.cpp (line 330) <https://reviews.apache.org/r/37303/#comment149690> indent by 4 spaces. src/scheduler/scheduler.cpp (line 346) <https://reviews.apache.org/r/37303/#comment149691> also print the response.get().status? src/scheduler/scheduler.cpp (line 436) <https://reviews.apache.org/r/37303/#comment149694> why is this method private but most others are protected? src/scheduler/scheduler.cpp (line 447) <https://reviews.apache.org/r/37303/#comment149693> const? src/scheduler/scheduler.cpp (line 475) <https://reviews.apache.org/r/37303/#comment149685> as discussed, please make this a paramter to Mesos() constructor. add a TODO for now and follow up in a different patch. - Vinod Kone On Aug. 11, 2015, 12:17 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37303/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 12:17 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2552 > https://issues.apache.org/jira/browse/MESOS-2552 > > > Repository: mesos > > > Description > ------- > > This changes moves scheduler library to http. The change to remove auth + > install,receive handlers are in other reviews. > > > Diffs > ----- > > src/common/http.hpp 98a12709ae5fcbf4ce3e37d164bff43818096838 > src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 > src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 > > Diff: https://reviews.apache.org/r/37303/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
