> On Aug. 11, 2015, 7:06 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166
> > <https://reviews.apache.org/r/36837/diff/8/?file=1034022#file1034022line166>
> >
> >     This line breaks the build on my machine OS X 10.10, and I'm not sure 
> > how to fix it because CMake's weird string eval semantics make it hard to 
> > just pass a normal quoted string in.
> >     
> >     Does this break on your machien too?

On investigation with the exact syntax provided here, the flag 
`-DGTEST_LANG_CXX11` is passed as a flag to `make`, not the compiler. So you 
end up with an error that's like "unknown flags -D, -G, -T, ...". That's not 
desired behavior.

When you replace it with something that runs `make 
CPPFLAGS="-DGTEST_USE_OWN_TR1_TUPLE -DGTEST_LANG_CXX11"`, it seems to not 
compile becuase of the second flag. When you remove that, it suddenly works 
again.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/#review94974
-----------------------------------------------------------


On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36837/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 3:24 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
>     https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 711809e808ebd0ed95d62270220e016ba6f41dca 
>   3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz 
> d45d9894b0214f5f02a88f6da5c258327110efd8 
>   3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 97727537778511ca5a10be4f3c25cd21d9166669 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 
>   3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a 
> 
> Diff: https://reviews.apache.org/r/36837/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to