> On Aug. 11, 2015, 7:04 p.m., Vinod Kone wrote:
> > src/tests/common/http_tests.cpp, lines 40-42
> > <https://reviews.apache.org/r/37328/diff/1/?file=1036934#file1036934line40>
> >
> >     reorder alphabetically.

Why ? We have alphabetical norms for using declarations "within" the same scope 
i.e. ( using std::string followed by using std::vector etc in order ). 

But we tend to go from stdc++ -> libprocess -> stout -> mesos_internal for 
using directives i.e. in order of header includes or am I missing something 
here ?

I am dropping the issue for now. Feel free to re-open though


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review94970
-----------------------------------------------------------


On Aug. 11, 2015, 7:47 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37328/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 7:47 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove namespace ambiguity. Needed for r37303
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e 
> 
> Diff: https://reviews.apache.org/r/37328/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to