-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37399/#review95122
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/network/port_mapping.cpp (lines 883 - 891)
<https://reviews.apache.org/r/37399/#comment149939>

    Can you do the following:
    
    ```
    if (statistics.isSome()) {
      ...
    } else if (statistics.isNone()) {
      // Add some comments about why you want to ignore this case.
    } else {
      cerr << "...";
    }
    ```



src/slave/containerizer/isolators/network/port_mapping.cpp (lines 900 - 902)
<https://reviews.apache.org/r/37399/#comment149940>

    Ditto here.


- Jie Yu


On Aug. 12, 2015, 4:57 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37399/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 4:57 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-3252
>     https://issues.apache.org/jira/browse/MESOS-3252
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore no statistics condition for containers with no qdisc.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 6d635d4dd902fd3863cce689a7791f12d22c3e0c 
> 
> Diff: https://reviews.apache.org/r/37399/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to